From 6899b9b9f3c38a22bf410daac51f5bfab49e3c28 Mon Sep 17 00:00:00 2001
From: Luca <Luca@hackerspace-bamberg.de>
Date: Fri, 21 Apr 2023 21:29:21 +0200
Subject: [PATCH] Merge 'redirects' app into 'pages'

---
 requirements.txt                              |  7 ++---
 shiftregister/metrics/urls.py                 |  2 +-
 shiftregister/pages/admin.py                  |  5 ++--
 .../pages/default_content/about.html          |  1 +
 shiftregister/pages/default_content/faq.html  |  1 +
 shiftregister/pages/default_content/map.html  |  1 +
 .../pages/management/commands/importhtml.py   | 13 +++++++---
 .../0002_page_kind_alter_page_title.py        | 26 +++++++++++++++++++
 shiftregister/pages/models.py                 | 16 ++++++++++--
 shiftregister/pages/templates/page.html       |  4 +--
 shiftregister/pages/views.py                  | 23 ++++++++++++++--
 shiftregister/redirects/__init__.py           |  0
 shiftregister/redirects/admin.py              |  6 -----
 shiftregister/redirects/apps.py               |  6 -----
 .../redirects/migrations/0001_initial.py      | 20 --------------
 .../redirects/migrations/__init__.py          |  0
 shiftregister/redirects/models.py             | 11 --------
 shiftregister/redirects/tests.py              |  3 ---
 shiftregister/redirects/urls.py               |  8 ------
 shiftregister/redirects/views.py              |  9 -------
 shiftregister/settings.py                     |  1 -
 shiftregister/signage/urls.py                 |  8 +++---
 shiftregister/urls.py                         |  7 +++--
 23 files changed, 90 insertions(+), 88 deletions(-)
 create mode 100644 shiftregister/pages/migrations/0002_page_kind_alter_page_title.py
 delete mode 100644 shiftregister/redirects/__init__.py
 delete mode 100644 shiftregister/redirects/admin.py
 delete mode 100644 shiftregister/redirects/apps.py
 delete mode 100644 shiftregister/redirects/migrations/0001_initial.py
 delete mode 100644 shiftregister/redirects/migrations/__init__.py
 delete mode 100644 shiftregister/redirects/models.py
 delete mode 100644 shiftregister/redirects/tests.py
 delete mode 100644 shiftregister/redirects/urls.py
 delete mode 100644 shiftregister/redirects/views.py

diff --git a/requirements.txt b/requirements.txt
index 263947a..bc37368 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,7 +1,7 @@
-## The following requirements were added by pip freeze:
 amqp==5.1.1
 asgiref==3.5.0
 async-timeout==4.0.2
+beautifulsoup4==4.12.2
 billiard==3.6.4.0
 celery==5.2.6
 certifi==2021.10.8
@@ -12,14 +12,14 @@ click-plugins==1.1.1
 click-repl==0.2.0
 Deprecated==1.2.13
 Django==4.0.4
-git+https://github.com/kikeh/django-dynamic-preferences@375f1a54dba91f81880a86f4a44bc2c42ceab067#egg=django-dynamic-preferences
+django-dynamic-preferences==1.15.0
 django-phonenumber-field==6.1.0
 icalendar==4.0.9
 idna==3.3
 kombu==5.2.4
 librabbitmq==2.0.0
 packaging==21.3
-persisting-theory==0.2.1
+persisting-theory==1.0
 phonenumbers==8.12.47
 prompt-toolkit==3.0.29
 psycopg2-binary==2.9.3
@@ -30,6 +30,7 @@ redis==4.2.2
 requests==2.27.1
 sentry-sdk==1.5.10
 six==1.16.0
+soupsieve==2.4.1
 sqlparse==0.4.2
 urllib3==1.26.9
 vine==5.0.0
diff --git a/shiftregister/metrics/urls.py b/shiftregister/metrics/urls.py
index 30dff2f..2be3bce 100644
--- a/shiftregister/metrics/urls.py
+++ b/shiftregister/metrics/urls.py
@@ -3,5 +3,5 @@ from django.urls import path
 from . import views
 
 urlpatterns = [
-    path("", views.metrics, name="metrics"),
+    path("metrics", views.metrics, name="metrics"),
 ]
diff --git a/shiftregister/pages/admin.py b/shiftregister/pages/admin.py
index 3f24906..24b829a 100644
--- a/shiftregister/pages/admin.py
+++ b/shiftregister/pages/admin.py
@@ -13,7 +13,6 @@ def reimport(modeladmin, request, queryset):
 
 @admin.register(Page)
 class PageAdmin(admin.ModelAdmin):
-    readonly_fields = ("url",)
-    fields = ("url", "content", "title", "visible")
-    list_display = ("title", "url", "visible")
+    fields = ("url", "content", "title", "visible", "kind")
+    list_display = ("url", "title", "visible", "kind")
     actions = (reimport,)
diff --git a/shiftregister/pages/default_content/about.html b/shiftregister/pages/default_content/about.html
index 095b910..3c3b271 100644
--- a/shiftregister/pages/default_content/about.html
+++ b/shiftregister/pages/default_content/about.html
@@ -1,3 +1,4 @@
+<title>Über diese Seite/Impressum</title>
 <div class="content">
     Wir speichern die folgenden Daten, wenn du dich bei uns registrierst:
     <ul>
diff --git a/shiftregister/pages/default_content/faq.html b/shiftregister/pages/default_content/faq.html
index c341136..0f6cef6 100644
--- a/shiftregister/pages/default_content/faq.html
+++ b/shiftregister/pages/default_content/faq.html
@@ -1,3 +1,4 @@
+<title>Häufig gestellte Fragen</title>
 <div class="content">
     <h5 class="mb-2">Wann gibt es Schichten?</h5>
     <p>
diff --git a/shiftregister/pages/default_content/map.html b/shiftregister/pages/default_content/map.html
index a580da5..54dd679 100644
--- a/shiftregister/pages/default_content/map.html
+++ b/shiftregister/pages/default_content/map.html
@@ -1 +1,2 @@
+<title>Karte</title>
 <h5 class="subtitle">Hier erscheint bald die Karte mit allen Schichtstandorten</h5>
diff --git a/shiftregister/pages/management/commands/importhtml.py b/shiftregister/pages/management/commands/importhtml.py
index 24dccf2..9682f3c 100644
--- a/shiftregister/pages/management/commands/importhtml.py
+++ b/shiftregister/pages/management/commands/importhtml.py
@@ -1,3 +1,4 @@
+from bs4 import BeautifulSoup
 from django.core.management.base import BaseCommand, CommandError
 from ...models import Page
 from pathlib import Path
@@ -20,7 +21,13 @@ class Command(BaseCommand):
             p, created = Page.objects.get_or_create(url=slug)
             if (not created) and (not options["force"]):
                 continue
-            p.content = file.read_text()
-            p.title = slug
+
+            soup = BeautifulSoup(file.read_text(), "html.parser")
+            if soup.title:
+                p.title = soup.title.string
+                soup.title.decompose()
+            else:
+                p.title = slug.title()
+            p.content = str(soup).strip()
             p.save()
-            print(f"created new page for slug {slug}")
+            print(f'created new page "{p.title}" for slug {slug}')
diff --git a/shiftregister/pages/migrations/0002_page_kind_alter_page_title.py b/shiftregister/pages/migrations/0002_page_kind_alter_page_title.py
new file mode 100644
index 0000000..d3c8828
--- /dev/null
+++ b/shiftregister/pages/migrations/0002_page_kind_alter_page_title.py
@@ -0,0 +1,26 @@
+# Generated by Django 4.0.4 on 2023-04-21 18:28
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("pages", "0001_initial"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="page",
+            name="kind",
+            field=models.CharField(
+                choices=[("redirect", "Redirect"), ("regular", "Regular page")],
+                default="regular",
+                max_length=8,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="page",
+            name="title",
+            field=models.CharField(blank=True, max_length=200),
+        ),
+    ]
diff --git a/shiftregister/pages/models.py b/shiftregister/pages/models.py
index ec75262..0f9d14e 100644
--- a/shiftregister/pages/models.py
+++ b/shiftregister/pages/models.py
@@ -4,10 +4,22 @@ from django.db import models
 
 
 class Page(models.Model):
+    REDIRECT = "redirect"
+    REGULAR = "regular"
+    KIND_CHOICES = [
+        (REDIRECT, "Redirect"),
+        (REGULAR, "Regular page"),
+    ]
+
     url = models.fields.SlugField(unique=True)
     content = models.TextField()
     visible = models.BooleanField(default=True)
-    title = models.CharField(max_length=200)
+    title = models.CharField(blank=True, max_length=200)
+    kind = models.CharField(choices=KIND_CHOICES, default=REGULAR, max_length=8)
 
     def __str__(self):
-        return f"Page {self.url}"
+        return (
+            f"{self.get_kind_display()} {self.url}" + f" => {self.content}"
+            if self.kind == Page.REDIRECT
+            else ""
+        )
diff --git a/shiftregister/pages/templates/page.html b/shiftregister/pages/templates/page.html
index 2dd967e..875daea 100644
--- a/shiftregister/pages/templates/page.html
+++ b/shiftregister/pages/templates/page.html
@@ -1,6 +1,6 @@
 {% extends "base.html" %}
 
-{% block title %}{{page.title}}{% endblock %}
+{% block title %}{{ page.title }}{% endblock %}
 
 {% block navbar %}
 <div class="navbar-start">
@@ -11,7 +11,7 @@
     <p class="navbar-item has-text-danger">Bestätige deine Telefonnummer über den Link in der SMS</p>
 {% endif %}
 {% if helper.important_shift %}
-    <a class="navbar-item" href="{% url 'shift' helper.important_shift.pk %}">{%if helper.important_shift.is_running%}Laufende{% else %}Nächste{% endif %} Schicht ({{ helper.important_shift.start_at|date:"H:i" }})</a>
+    <a class="navbar-item" href="{% url 'shift' helper.important_shift.pk %}">{% if helper.important_shift.is_running %}Laufende{% else %}Nächste{% endif %} Schicht ({{ helper.important_shift.start_at|date:"H:i" }})</a>
 {% endif %}
 {% endif %}
 </div>
diff --git a/shiftregister/pages/views.py b/shiftregister/pages/views.py
index 9b09722..72944ea 100644
--- a/shiftregister/pages/views.py
+++ b/shiftregister/pages/views.py
@@ -1,11 +1,30 @@
 from django.views.generic import DetailView
-from django.shortcuts import render
+from django.shortcuts import redirect
+from django.core.validators import URLValidator
+from django.core.exceptions import ValidationError
+from django.http import HttpResponseNotFound
 from .models import Page
 
 # Create your views here.
 
 
 class PageView(DetailView):
-    template_name = "page.html"
     queryset = Page.objects.filter(visible=True)
     slug_field = "url"
+    template_name = "page.html"
+
+    def render_to_response(self, context, **response_kwargs):
+        page = self.object
+
+        if self.object.kind == Page.REDIRECT:
+            target = str(page.content)
+
+            validate_url = URLValidator()
+            try:
+                validate_url(page.content)
+            except ValidationError:
+                return HttpResponseNotFound()
+
+            return redirect(page.content, permanent=True)
+
+        return super().render_to_response(context, **response_kwargs)
diff --git a/shiftregister/redirects/__init__.py b/shiftregister/redirects/__init__.py
deleted file mode 100644
index e69de29..0000000
diff --git a/shiftregister/redirects/admin.py b/shiftregister/redirects/admin.py
deleted file mode 100644
index e5de724..0000000
--- a/shiftregister/redirects/admin.py
+++ /dev/null
@@ -1,6 +0,0 @@
-from django.contrib import admin
-
-from .models import Redirect
-
-# Register your models here.
-admin.site.register(Redirect)
diff --git a/shiftregister/redirects/apps.py b/shiftregister/redirects/apps.py
deleted file mode 100644
index 2e0e9d7..0000000
--- a/shiftregister/redirects/apps.py
+++ /dev/null
@@ -1,6 +0,0 @@
-from django.apps import AppConfig
-
-
-class RedirectsConfig(AppConfig):
-    default_auto_field = "django.db.models.BigAutoField"
-    name = "shiftregister.redirects"
diff --git a/shiftregister/redirects/migrations/0001_initial.py b/shiftregister/redirects/migrations/0001_initial.py
deleted file mode 100644
index aa6c410..0000000
--- a/shiftregister/redirects/migrations/0001_initial.py
+++ /dev/null
@@ -1,20 +0,0 @@
-# Generated by Django 4.0.4 on 2022-05-26 13:04
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    initial = True
-
-    dependencies = []
-
-    operations = [
-        migrations.CreateModel(
-            name="Redirect",
-            fields=[
-                ("slug", models.SlugField(primary_key=True, serialize=False)),
-                ("target", models.URLField()),
-            ],
-        ),
-    ]
diff --git a/shiftregister/redirects/migrations/__init__.py b/shiftregister/redirects/migrations/__init__.py
deleted file mode 100644
index e69de29..0000000
diff --git a/shiftregister/redirects/models.py b/shiftregister/redirects/models.py
deleted file mode 100644
index c339ea4..0000000
--- a/shiftregister/redirects/models.py
+++ /dev/null
@@ -1,11 +0,0 @@
-from django.db import models
-
-# Create your models here.
-
-
-class Redirect(models.Model):
-    slug = models.SlugField(primary_key=True)
-    target = models.URLField()
-
-    def __str__(self):
-        return f"{self.slug} => {self.target}"
diff --git a/shiftregister/redirects/tests.py b/shiftregister/redirects/tests.py
deleted file mode 100644
index 7ce503c..0000000
--- a/shiftregister/redirects/tests.py
+++ /dev/null
@@ -1,3 +0,0 @@
-from django.test import TestCase
-
-# Create your tests here.
diff --git a/shiftregister/redirects/urls.py b/shiftregister/redirects/urls.py
deleted file mode 100644
index a06476b..0000000
--- a/shiftregister/redirects/urls.py
+++ /dev/null
@@ -1,8 +0,0 @@
-from django.urls import path
-
-from . import views
-
-app_name = "redirects"
-urlpatterns = [
-    path("<slug:slug>", views.redir, name="redir"),
-]
diff --git a/shiftregister/redirects/views.py b/shiftregister/redirects/views.py
deleted file mode 100644
index 7e5c86b..0000000
--- a/shiftregister/redirects/views.py
+++ /dev/null
@@ -1,9 +0,0 @@
-from django.shortcuts import redirect, get_object_or_404
-from .models import Redirect
-
-# Create your views here.
-
-
-def redir(request, slug):
-    obj = get_object_or_404(Redirect, pk=slug)
-    return redirect(obj.target)
diff --git a/shiftregister/settings.py b/shiftregister/settings.py
index 1ac8423..7c70ebf 100644
--- a/shiftregister/settings.py
+++ b/shiftregister/settings.py
@@ -45,7 +45,6 @@ INSTALLED_APPS = [
     "shiftregister.pages.apps.PagesConfig",
     "shiftregister.metrics.apps.MetricsConfig",
     "shiftregister.signage.apps.SignageConfig",
-    "shiftregister.redirects.apps.RedirectsConfig",
     "django.contrib.admin",
     "django.contrib.auth",
     "django.contrib.contenttypes",
diff --git a/shiftregister/signage/urls.py b/shiftregister/signage/urls.py
index 04d41f1..4796703 100644
--- a/shiftregister/signage/urls.py
+++ b/shiftregister/signage/urls.py
@@ -4,8 +4,8 @@ from . import views
 
 app_name = "signage"
 urlpatterns = [
-    path("team/worklist", views.worklist, name="worklist"),
-    path("team/worklist/add/<int:shiftid>", views.add_teammember, name="work_add"),
-    path("team/worklist/remove/<int:pk>", views.remove_teammember, name="work_remove"),
-    path("team/terminal", views.terminal, name="terminal"),
+    path("worklist", views.worklist, name="worklist"),
+    path("worklist/add/<int:shiftid>", views.add_teammember, name="work_add"),
+    path("worklist/remove/<int:pk>", views.remove_teammember, name="work_remove"),
+    path("terminal", views.terminal, name="terminal"),
 ]
diff --git a/shiftregister/urls.py b/shiftregister/urls.py
index 2f18ccc..b422eee 100644
--- a/shiftregister/urls.py
+++ b/shiftregister/urls.py
@@ -17,11 +17,10 @@ from django.contrib import admin
 from django.urls import include, path
 
 urlpatterns = [
+    path("", include("shiftregister.pages.urls")),
+    path("", include("shiftregister.metrics.urls")),
     path("", include("shiftregister.app.urls")),
     path("team/", include("shiftregister.team.urls")),
+    path("team/", include("shiftregister.signage.urls")),
     path("admin/", admin.site.urls),
-    path("p/", include("shiftregister.pages.urls")),
-    path("r/", include("shiftregister.redirects.urls")),
-    path("metrics/", include("shiftregister.metrics.urls")),
-    path("", include("shiftregister.signage.urls")),
 ]