From ec7fb0615c7840c790672b8ddea2be5aec3aed36 Mon Sep 17 00:00:00 2001
From: Xu <git@xumail.de>
Date: Sun, 18 Feb 2024 11:34:47 +0100
Subject: [PATCH] add target="_blank" to links

---
 includes/pages/user_shifts.php              | 2 +-
 resources/lang/de_DE/default.po             | 8 ++++----
 resources/views/admin/schedule/index.twig   | 2 +-
 resources/views/layouts/maintenance.html    | 4 ++--
 resources/views/layouts/parts/footer.twig   | 4 ++--
 resources/views/pages/settings/profile.twig | 2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/includes/pages/user_shifts.php b/includes/pages/user_shifts.php
index c1710e04..bd8d5478 100644
--- a/includes/pages/user_shifts.php
+++ b/includes/pages/user_shifts.php
@@ -374,7 +374,7 @@ function ical_hint()
 
     return heading(__('iCal export and API') . ' ' . button_help('user/ical'), 2)
         . '<p>' . sprintf(
-            __('Export your own shifts. <a href="%s">iCal format</a> or <a href="%s">JSON format</a> available (please keep secret, otherwise <a href="%s">reset the api key</a>).'),
+            __('Export your own shifts. <a href="%s" target="_blank">iCal format</a> or <a href="%s" target="_blank">JSON format</a> available (please keep secret, otherwise <a href="%s">reset the api key</a>).'),
             url('/ical', ['key' => $user->api_key]),
             url('/shifts-json-export', ['key' => $user->api_key]),
             url('/user-myshifts', ['reset' => 1])
diff --git a/resources/lang/de_DE/default.po b/resources/lang/de_DE/default.po
index 23c123e4..513c437b 100644
--- a/resources/lang/de_DE/default.po
+++ b/resources/lang/de_DE/default.po
@@ -837,12 +837,12 @@ msgid "iCal export and API"
 msgstr "iCal Export und API"
 
 msgid ""
-"Export your own shifts. <a href=\"%s\">iCal format</a> or <a href=\"%s"
-"\">JSON format</a> available (please keep secret, otherwise <a href=\"%s"
+"Export your own shifts. <a href=\"%s\" target=\"_blank\">iCal format</a> or <a href=\"%s"
+"\" target=\"_blank\">JSON format</a> available (please keep secret, otherwise <a href=\"%s"
 "\">reset the api key</a>)."
 msgstr ""
-"Exportiere Deine Schichten. <a href=\"%s\">iCal Format</a> oder <a href=\"%s"
-"\">JSON Format</a> verfügbar (Link bitte geheimhalten, sonst <a href=\"%s"
+"Exportiere Deine Schichten. <a href=\"%s\" target=\"_blank\">iCal Format</a> oder <a href=\"%s"
+"\" target=\"_blank\">JSON Format</a> verfügbar (Link bitte geheimhalten, sonst <a href=\"%s"
 "\">API-Key zurücksetzen</a>)."
 
 msgid "Show API Key"
diff --git a/resources/views/admin/schedule/index.twig b/resources/views/admin/schedule/index.twig
index 2e7352c7..d19a24a8 100644
--- a/resources/views/admin/schedule/index.twig
+++ b/resources/views/admin/schedule/index.twig
@@ -35,7 +35,7 @@
                             {% for schedule in schedules %}
                                 <tr>
                                     <td>{{ schedule.name }}</td>
-                                    <td><a href="{{ schedule.url }}" target="_blank">{{ schedule.url }}</a></td>
+                                    <td><a href="{{ schedule.url }}" target="_blank" rel="noopener">{{ schedule.url }}</a></td>
                                     <td>
                                         <form method="post" action="{{ url('/admin/schedule/edit/' ~ schedule.id) }}">
                                             {{ csrf() }}
diff --git a/resources/views/layouts/maintenance.html b/resources/views/layouts/maintenance.html
index 305dbb03..4f4b4732 100644
--- a/resources/views/layouts/maintenance.html
+++ b/resources/views/layouts/maintenance.html
@@ -64,8 +64,8 @@
     </div>
 
     <div>
-        <a href="https://github.com/engelsystem/engelsystem/issues">Bugs / Features</a>
-        · <a href="https://github.com/engelsystem/engelsystem/">Development Platform</a>
+        <a href="https://github.com/engelsystem/engelsystem/issues" target="_blank" rel="noopener">Bugs / Features</a>
+        · <a href="https://github.com/engelsystem/engelsystem/" target="_blank" rel="noopener">Development Platform</a>
     </div>
 </div>
 
diff --git a/resources/views/layouts/parts/footer.twig b/resources/views/layouts/parts/footer.twig
index a5e6580b..56a048d9 100644
--- a/resources/views/layouts/parts/footer.twig
+++ b/resources/views/layouts/parts/footer.twig
@@ -46,8 +46,8 @@
                 </a> ·
             {% endif %}
         {% endfor %}
-        <a href="https://github.com/engelsystem/engelsystem/issues">{{ __('footer.issues') }}</a>
-        · <a href="https://github.com/engelsystem/engelsystem/">{{ __('footer.github') }}</a>
+        <a href="https://github.com/engelsystem/engelsystem/issues" target="_blank" rel="noopener">{{ __('footer.issues') }}</a>
+        · <a href="https://github.com/engelsystem/engelsystem/" target="_blank" rel="noopener">{{ __('footer.github') }}</a>
         · <a href="{{ url('/credits') }}">{{ __('credits.title') }}</a>
     </div>
 </div>
diff --git a/resources/views/pages/settings/profile.twig b/resources/views/pages/settings/profile.twig
index e7e33e1b..26213e19 100644
--- a/resources/views/pages/settings/profile.twig
+++ b/resources/views/pages/settings/profile.twig
@@ -160,7 +160,7 @@
                         'form_text': (tShirtLink ? m.icon('info-circle')
                             ~ ' <a href="'
                             ~ tShirtLink|escape('html_attr')
-                            ~ '">'
+                            ~ '" target="_blank" rel="noopener">'
                             ~ __('settings.profile.shirt.link')|e
                             ~ '</a>' : ''),
                     }) }}