iger
/
engelsystem
9
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Delete all sessions on password reset

This commit is contained in:
Igor Scheller 2023-09-17 20:25:48 +02:00 committed by Michael Weimann
parent 5c59fec1cf
commit dbb089315f
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Controllers/PasswordResetController.php
View File

@ -96,6 +96,8 @@ class PasswordResetController extends BaseController
auth()->setPassword($reset->user, $data['password']); auth()->setPassword($reset->user, $data['password']);
$reset->delete(); $reset->delete();
$reset->user->sessions()->getQuery()->delete();
return $this->showView('pages/password/reset-success', ['type' => 'reset']); return $this->showView('pages/password/reset-success', ['type' => 'reset']);
} }

9
tests/Unit/Controllers/PasswordResetControllerTest.php
View File

@ -15,6 +15,7 @@ use Engelsystem\Http\Request;
use Engelsystem\Http\Response; use Engelsystem\Http\Response;
use Engelsystem\Http\Validation\Validator; use Engelsystem\Http\Validation\Validator;
use Engelsystem\Mail\EngelsystemMailer; use Engelsystem\Mail\EngelsystemMailer;
use Engelsystem\Models\Session as SessionModel;
use Engelsystem\Models\User\PasswordReset; use Engelsystem\Models\User\PasswordReset;
use Engelsystem\Models\User\User; use Engelsystem\Models\User\User;
use Engelsystem\Renderer\Renderer; use Engelsystem\Renderer\Renderer;
@ -147,6 +148,8 @@ class PasswordResetControllerTest extends ControllerTest
['password' => $password, 'password_confirmation' => $password], ['password' => $password, 'password_confirmation' => $password],
['token' => $token->token] ['token' => $token->token]
); );
SessionModel::factory()->create(); // Some other session
SessionModel::factory(3)->create(['user_id' => $user->id]);
$controller = $this->getController( $controller = $this->getController(
'pages/password/reset-success', 'pages/password/reset-success',
@ -162,6 +165,12 @@ class PasswordResetControllerTest extends ControllerTest
$this->assertEmpty((new PasswordReset())->find($user->id)); $this->assertEmpty((new PasswordReset())->find($user->id));
$this->assertNotNull(auth()->authenticate($user->name, $password)); $this->assertNotNull(auth()->authenticate($user->name, $password));
$this->assertHasNoNotifications(); $this->assertHasNoNotifications();
$this->assertEmpty(
SessionModel::whereUserId($user->id)->get(),
'All user sessions should be deleted after successful password reset'
);
$this->assertCount(1, SessionModel::all()); // Another session should be still there
} }
/** /**