Add function-paren-newline ESLint rule; align config code style (#1000)

* unify indentation in config.default.php

* add eslint rule `function-paren-newline`

* fix `function-param-newline` lint rule

.eslintrc.json

@@ -3,6 +3,7 @@
   "extends": [ "plugin:editorconfig/all" ],
   "plugins": [ "editorconfig" ],
   "rules": {
+    "function-paren-newline": "error",
     "prefer-arrow-callback": "error",
     "no-var": "error",
     "quotes": [

config/config.default.php

@@ -280,7 +280,7 @@ return [
     'enable_goody'            => (bool)env('ENABLE_GOODY', false),
 
     // Enables the food voucher in the user profile
-    'enable_voucher'            => (bool)env('ENABLE_VOUCHER', true),
+    'enable_voucher'          => (bool)env('ENABLE_VOUCHER', true),
 
     // Number of shifts to freeload until angel is locked for shift signup.
     'max_freeloadable_shifts' => env('MAX_FREELOADABLE_SHIFTS', 2),

resources/assets/js/dashboard.js

@@ -25,9 +25,8 @@ ready(() => {
   document.getElementById('dashboard-fullscreen')
     ?.addEventListener('click', (event) => {
       event.preventDefault();
-      document.querySelectorAll(
-        '#navbar-collapse-1,.navbar-nav,.navbar-toggler,#footer,#fullscreen-button'
-      ).forEach((element) => {
+      const removeElementsSelector = '#navbar-collapse-1,.navbar-nav,.navbar-toggler,#footer,#fullscreen-button';
+      document.querySelectorAll(removeElementsSelector).forEach((element) => {
         element.parentNode.removeChild(element);
       });