From 665e444e881ec2ca4378b346d45dbc488ac89a2b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Janne=20He=C3=9F?= <janne@hess.ooo>
Date: Tue, 23 Apr 2019 12:42:01 +0200
Subject: [PATCH] Support disabling the DECT field

It's a really chaos-event-specific feature and is confusing for many
people on non-chaos events.
---
 config/config.default.php      | 3 +++
 includes/pages/admin_user.php  | 4 +++-
 includes/pages/guest_login.php | 9 +++++----
 includes/view/User_view.php    | 5 +++--
 4 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/config/config.default.php b/config/config.default.php
index 86320a4a..1830500e 100644
--- a/config/config.default.php
+++ b/config/config.default.php
@@ -99,6 +99,9 @@ return [
     // The minimum length for passwords
     'min_password_length'     => 8,
 
+    // Whether the DECT field should be enabled
+    'enable_dect'             => true,
+
     // Enables the T-Shirt configuration on signup and profile
     'enable_tshirt_size'      => true,
 
diff --git a/includes/pages/admin_user.php b/includes/pages/admin_user.php
index d42c3b39..773238ce 100644
--- a/includes/pages/admin_user.php
+++ b/includes/pages/admin_user.php
@@ -55,7 +55,9 @@ function admin_user()
         $html .= '  <tr><td>Name</td><td>' . '<input size="40" name="eName" value="' . $user_source->personalData->last_name . '" class="form-control"></td></tr>' . "\n";
         $html .= '  <tr><td>Vorname</td><td>' . '<input size="40" name="eVorname" value="' . $user_source->personalData->first_name . '" class="form-control"></td></tr>' . "\n";
         $html .= '  <tr><td>Handy</td><td>' . '<input type= "tel" size="40" name="eHandy" value="' . $user_source->contact->mobile . '" class="form-control"></td></tr>' . "\n";
-        $html .= '  <tr><td>DECT</td><td>' . '<input size="40" name="eDECT" value="' . $user_source->contact->dect . '" class="form-control"></td></tr>' . "\n";
+        if (config('enable_dect')) {
+            $html .= '  <tr><td>DECT</td><td>' . '<input size="40" name="eDECT" value="' . $user_source->contact->dect . '" class="form-control"></td></tr>' . "\n";
+        }
         if ($user_source->settings->email_human) {
             $html .= "  <tr><td>email</td><td>" . '<input type="email" size="40" name="eemail" value="' . $user_source->email . '" class="form-control"></td></tr>' . "\n";
         }
diff --git a/includes/pages/guest_login.php b/includes/pages/guest_login.php
index c636a36c..2f206bcc 100644
--- a/includes/pages/guest_login.php
+++ b/includes/pages/guest_login.php
@@ -42,6 +42,7 @@ function guest_register()
     $authUser = auth()->user();
     $tshirt_sizes = config('tshirt_sizes');
     $enable_tshirt_size = config('enable_tshirt_size');
+    $enable_dect = config('enable_dect');
     $min_password_length = config('min_password_length');
     $config = config();
     $request = request();
@@ -167,7 +168,7 @@ function guest_register()
         if ($request->has('prename')) {
             $preName = strip_request_item('prename');
         }
-        if ($request->has('dect')) {
+        if ($enable_dect && $request->has('dect')) {
             if (strlen(strip_request_item('dect')) <= 40) {
                 $dect = strip_request_item('dect');
             } else {
@@ -339,10 +340,10 @@ function guest_register()
                 ]),
                 div('col-md-6', [
                     div('row', [
-                        div('col-sm-4', [
+                        $enable_dect ? div('col-sm-4', [
                             form_text('dect', __('DECT'), $dect)
-                        ]),
-                        div('col-sm-4', [
+                        ]) : '',
+                        div($enable_dect ? 'col-sm-4' : 'col-sm-12', [
                             form_text('mobile', __('Mobile'), $mobile)
                         ]),
                     ]),
diff --git a/includes/view/User_view.php b/includes/view/User_view.php
index 4768f4ac..cc2c3153 100644
--- a/includes/view/User_view.php
+++ b/includes/view/User_view.php
@@ -25,6 +25,7 @@ function User_settings_view(
     $tshirt_sizes
 ) {
     $personalData = $user_source->personalData;
+    $enable_dect = config('enable_dect');
     return page_with_title(settings_title(), [
         msg(),
         div('row', [
@@ -49,7 +50,7 @@ function User_settings_view(
                         $buildup_start_date,
                         $teardown_end_date
                     ),
-                    form_text('dect', __('DECT'), $user_source->contact->dect),
+                    $enable_dect ? form_text('dect', __('DECT'), $user_source->contact->dect) : '',
                     form_text('mobile', __('Mobile'), $user_source->contact->mobile),
                     form_text('mail', __('E-Mail') . ' ' . entry_required(), $user_source->email),
                     form_checkbox(
@@ -953,7 +954,7 @@ function render_user_tshirt_hint()
 function render_user_dect_hint()
 {
     $user = auth()->user();
-    if ($user->state->arrived && !$user->contact->dect) {
+    if ($user->state->arrived && config('enable_dect') && !$user->contact->dect) {
         $text = __('You need to specify a DECT phone number in your settings! If you don\'t have a DECT phone, just enter \'-\'.');
         return render_profile_link($text, null, 'alert-link');
     }