From 395f6706d6fe7b59df5caa4158d5e8ff268368ef Mon Sep 17 00:00:00 2001 From: Igor Scheller Date: Mon, 30 Dec 2019 01:44:09 +0100 Subject: [PATCH] Message: Add coverage, fix method hints --- .../2019_11_25_000000_create_messages_table.php | 2 +- src/Models/Message.php | 8 ++------ tests/Unit/Models/MessageTest.php | 12 ++++++++++++ 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/db/migrations/2019_11_25_000000_create_messages_table.php b/db/migrations/2019_11_25_000000_create_messages_table.php index b34a6c19..e2c0f253 100644 --- a/db/migrations/2019_11_25_000000_create_messages_table.php +++ b/db/migrations/2019_11_25_000000_create_messages_table.php @@ -75,7 +75,7 @@ class CreateMessagesTable extends Migration 'messages', function (Blueprint $table) { $table->increments('id'); - $this->references($table, 'users', 'user_id'); + $this->referencesUser($table); $this->references($table, 'users', 'receiver_id'); $table->boolean('read')->default(0); $table->text('text'); diff --git a/src/Models/Message.php b/src/Models/Message.php index cb658fc6..cf1a6160 100644 --- a/src/Models/Message.php +++ b/src/Models/Message.php @@ -20,15 +20,11 @@ use Illuminate\Support\Carbon; * @property Carbon|null $created_at * @property Carbon|null $updated_at * @property-read User $receiver - * @method static Builder|Message newModelQuery() - * @method static Builder|Message newQuery() - * @method static Builder|Message query() - * @method static Builder|Message whereCreatedAt($value) * @method static Builder|Message whereId($value) - * @method static Builder|Message whereRead($value) * @method static Builder|Message whereReceiverId($value) - * @method static Builder|Message whereSenderId($value) + * @method static Builder|Message whereRead($value) * @method static Builder|Message whereText($value) + * @method static Builder|Message whereCreatedAt($value) * @method static Builder|Message whereUpdatedAt($value) */ class Message extends BaseModel diff --git a/tests/Unit/Models/MessageTest.php b/tests/Unit/Models/MessageTest.php index 11af9a83..7fb3e028 100644 --- a/tests/Unit/Models/MessageTest.php +++ b/tests/Unit/Models/MessageTest.php @@ -76,6 +76,8 @@ class MessageTest extends TestCase /** * Tests that loading Messages works. * + * @covers \Engelsystem\Models\Message::__construct + * * @return void */ public function testLoad(): void @@ -96,6 +98,8 @@ class MessageTest extends TestCase /** * Tests that the Messages have the correct senders. * + * @covers \Engelsystem\Models\Message::user + * * @return void */ public function testSenders(): void @@ -108,6 +112,8 @@ class MessageTest extends TestCase /** * Tests that the Messages have the correct receivers. * + * @covers \Engelsystem\Models\Message::receiver + * * @return void */ public function testReceivers(): void @@ -120,6 +126,8 @@ class MessageTest extends TestCase /** * Tests that the Users have the correct sent Messages. * + * @covers \Engelsystem\Models\User\User::messagesSent + * * @return void */ public function testUserSentMessages(): void @@ -137,6 +145,8 @@ class MessageTest extends TestCase /** * Tests that the Users have the correct received Messages. * + * @covers \Engelsystem\Models\User\User::messagesReceived + * * @return void */ public function testUserReceivedMessages(): void @@ -153,6 +163,8 @@ class MessageTest extends TestCase /** * Tests that the user have the correct Messages. + * + * @covers \Engelsystem\Models\User\User::messages */ public function testUserMessages(): void {