From 1ec19b46f3311a0235c7d3e119e035559c9b4d14 Mon Sep 17 00:00:00 2001
From: msquare <msquare@notrademark.de>
Date: Thu, 29 Sep 2016 09:50:31 +0200
Subject: [PATCH] prohibit inline control structures on mailers

---
 includes/mailer/shifts_mailer.php | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/includes/mailer/shifts_mailer.php b/includes/mailer/shifts_mailer.php
index 8189883a..e1bf422b 100644
--- a/includes/mailer/shifts_mailer.php
+++ b/includes/mailer/shifts_mailer.php
@@ -48,9 +48,11 @@ function mail_shift_change($old_shift, $new_shift) {
   $message .= date("Y-m-d H:i", $new_shift["start"]) . " - " . date("H:i", $new_shift["end"]) . "\n";
   $message .= $new_room["Name"] . "\n";
   
-  foreach ($users as $user)
-    if ($user["email_shiftinfo"])
+  foreach ($users as $user) {
+    if ($user["email_shiftinfo"]) {
       engelsystem_email_to_user($user, '[engelsystem] ' . _("Your Shift has changed"), $message, true);
+    }
+  }
 }
 
 function mail_shift_delete($shift) {
@@ -64,9 +66,11 @@ function mail_shift_delete($shift) {
   $message .= date("Y-m-d H:i", $shift["start"]) . " - " . date("H:i", $shift["end"]) . "\n";
   $message .= $room["Name"] . "\n";
   
-  foreach ($users as $user)
-    if ($user["email_shiftinfo"])
+  foreach ($users as $user) {
+    if ($user["email_shiftinfo"]) {
       engelsystem_email_to_user($user, '[engelsystem] ' . _("Your Shift was deleted"), $message, true);
+    }
+  }
 }
 
 function mail_shift_assign($user, $shift) {