From 175c335810817ff3e989f368889274d3f09c08b1 Mon Sep 17 00:00:00 2001
From: Igor Scheller <igor.scheller@igorshp.de>
Date: Wed, 29 Aug 2018 18:08:45 +0200
Subject: [PATCH] Db::selectOne() should return null if result is empty

---
 includes/model/Shifts_model.php  | 2 +-
 includes/pages/user_myshifts.php | 2 +-
 src/Database/Db.php              | 9 +++++++--
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/includes/model/Shifts_model.php b/includes/model/Shifts_model.php
index 94513ff3..b5e3a205 100644
--- a/includes/model/Shifts_model.php
+++ b/includes/model/Shifts_model.php
@@ -182,7 +182,7 @@ function NeededAngeltypes_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
 /**
  * @param array $shift
  * @param array $angeltype
- * @return array
+ * @return array|null
  */
 function NeededAngeltype_by_Shift_and_Angeltype($shift, $angeltype)
 {
diff --git a/includes/pages/user_myshifts.php b/includes/pages/user_myshifts.php
index 5819f5c6..b61fc1e4 100644
--- a/includes/pages/user_myshifts.php
+++ b/includes/pages/user_myshifts.php
@@ -71,7 +71,7 @@ function user_myshifts()
                 $shifts_user['UID'],
             ]
         );
-        if (count($shift) > 0) {
+        if (!empty($shift)) {
             $freeloaded = $shift['freeloaded'];
             $freeload_comment = $shift['freeload_comment'];
 
diff --git a/src/Database/Db.php b/src/Database/Db.php
index f34d1564..c0871e68 100644
--- a/src/Database/Db.php
+++ b/src/Database/Db.php
@@ -45,14 +45,19 @@ class Db
      *
      * @param string $query
      * @param array  $bindings
-     * @return array
+     * @return array|null
      */
     public static function selectOne($query, array $bindings = [])
     {
         $result = self::connection()->selectOne($query, $bindings);
 
         // @TODO: remove typecast
-        return (array)$result;
+        $result = (array)$result;
+        if (empty($result)) {
+            return null;
+        }
+
+        return $result;
     }
 
     /**