Fix button types and remove unused classes

Co-authored-by: Thomas Rupprecht <rupprecht.thomas@gmail.com>

includes/pages/admin_user.php

@@ -120,7 +120,7 @@ function admin_user()
 
         $html .= '</td></tr>' . "\n";
         $html .= '</table>' . "\n" . '<br />' . "\n";
-        $html .= '<input type="submit" value="' . __('form.save') . '" class="btn btn-primary">';
+        $html .= '<button type="submit" class="btn btn-primary">' . __('form.save') . '</button>' . "\n";
         $html .= '</form>';
 
         $html .= '<hr />';
@@ -136,7 +136,7 @@ function admin_user()
         $html .= '  <tr><td>' . __('Confirm password') . '</td><td>' . '<input type="password" size="40" name="new_pw2" value="" class="form-control" autocomplete="new-password"></td></tr>' . "\n";
 
         $html .= '</table>' . "\n" . '<br />' . "\n";
-        $html .= '<input type="submit" value="' . __('form.save') . '" class="btn btn-primary">' . "\n";
+        $html .= '<button type="submit" class="btn btn-primary">' . __('form.save') . '</button>' . "\n";
         $html .= '</form>';
 
         $html .= '<hr />';
@@ -172,7 +172,7 @@ function admin_user()
 
             $html .= '</div><br>';
 
-            $html .= '<input type="submit" value="' . __('form.save') . '" class="btn btn-primary">' . "\n";
+            $html .= '<button type="submit" class="btn btn-primary">' . __('form.save') . '</button>' . "\n";
             $html .= '</form>';
 
             $html .= '<hr />';

includes/view/AngelTypes_view.php

@@ -188,15 +188,13 @@ function AngelType_view_buttons(
     if ($admin_angeltypes || $supporter) {
         $buttons[] = button(
             page_link_to('angeltypes', ['action' => 'edit', 'angeltype_id' => $angeltype->id]),
-            icon('pencil') . __('edit'),
-            'edit'
+            icon('pencil') . __('edit')
         );
     }
     if ($admin_angeltypes) {
         $buttons[] = button(
             page_link_to('angeltypes', ['action' => 'delete', 'angeltype_id' => $angeltype->id]),
-            icon('trash') . __('delete'),
-            'delete'
+            icon('trash') . __('delete')
         );
     }
 

includes/view/Rooms_view.php

@@ -62,8 +62,7 @@ function Room_view(Room $room, ShiftsFilterRenderer $shiftsFilterRenderer, Shift
         auth()->can('admin_rooms') ? buttons([
             button(
                 page_link_to('admin/rooms/edit/' . $room->id),
-                icon('pencil') . __('edit'),
-                'btn'
+                icon('pencil') . __('edit')
             ),
         ]) : '',
         $dect,

includes/view/ShiftTypes_view.php

@@ -73,13 +73,11 @@ function ShiftType_view(ShiftType $shifttype)
             button(page_link_to('shifttypes'), shifttypes_title(), 'back'),
             button(
                 page_link_to('shifttypes', ['action' => 'edit', 'shifttype_id' => $shifttype->id]),
-                icon('pencil') . __('edit'),
-                'edit'
+                icon('pencil') . __('edit')
             ),
             button(
                 page_link_to('shifttypes', ['action' => 'delete', 'shifttype_id' => $shifttype->id]),
                 icon('trash') . __('delete'),
-                'delete'
             ),
         ]),
         heading(__('Description'), 2),

resources/views/pages/user-shifts.html

@@ -52,7 +52,7 @@
             </div>
             <div class="row d-print-none">
                 <div class="col-md-12">
-                    <input class="btn btn-primary" type="submit" style="width:100%; margin: 1em 0" value="%filter%">
+                    <button class="btn btn-primary" type="submit" style="width:100%; margin: 1em 0">%filter%</button>
                 </div>
             </div>
         </div>